Skip to content

Conversation

mx-shift
Copy link
Contributor

No description provided.

@mx-shift mx-shift requested a review from bcantrill January 10, 2023 19:33
}
}

if part.has_tz() {
Copy link
Contributor

@andrewjstone andrewjstone Jan 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the s28 I'm seeing the secure MPU registers show up (with the same values as NS). This appears to be because the dregion is not 0. On the SP, the S registers properly don't show. Not really a huge issue, but figured I'd mention it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. This is a bug in ARMCore::has_tz() which assumes that all Cortex-M33 implementations have TrustZone-M. That is definitely not always true. I'll file a separate bug.

Copy link
Contributor

@andrewjstone andrewjstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Would be good to get this in for debugging purposes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants